Skip to content

Persist search and filter state in the URL and filter chips #96

Jump to bottom
Merged
merged 2 commits into from
Nov 11, 2026
Merged

Persist search and filter state in the URL and filter chips #96

merged 2 commits into from
Nov 11, 2026
+256 −24

Conversation

kfmelen
Copy link
Member

@kfmelen kfmelen commented Nov 11, 2026 •
edited
Loading

Summary

Search queries and filter selections are now stored in the URL, so results can be restored after a refresh, revisited with browser navigation, or shared with others.

Changes

  • Keep the search query and selected filters in sync with URL parameters.
  • Restore search and filter state when opening a URL directly.
  • Show active filters as removable chips outside the filter menu.
  • Keep chips inline with the Filter button on larger screens and below it on smaller screens.
  • Preserve the search state when navigating to and from game details.

Testing

  • Added component tests for URL state and search results.
  • Added end-to-end coverage for filter state, navigation, and responsive layouts.
  • Verified the frontend build and desktop and mobile filter layout tests.

Closes #83

@kfmelen kfmelen added the enhancement New feature or request label Nov 11, 2026
@kfmelen kfmelen added this to the Delivery four milestone Nov 11, 2026
@kfmelen kfmelen self-assigned this Nov 11, 2026
@kfmelen kfmelen requested a review from a team as a code owner November 11, 2026 09:28
@kfmelen kfmelen linked an issue Nov 11, 2026 that may be closed by this pull request
Keep search and filter state in the URL and show active filters #83
Closed
@martiasu martiasu self-requested a review November 11, 2026 09:32
martiasu
martiasu previously approved these changes Nov 11, 2026
View reviewed changes
Copy link
Member

@martiasu martiasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@kfmelen
Merge branch 'main' into 83-keep-search-and-filter-state-in-the-url-a…
338b552 
…nd-show-active-filters

# Conflicts:
#	T04-Project-2/frontend/src/components/GameCard.tsx
#	T04-Project-2/frontend/src/components/GameDetailPage.tsx
#	T04-Project-2/frontend/tests/components/SearchResults.test.tsx
#	T04-Project-2/frontend/tests/integration/journey.spec.ts
@kfmelen kfmelen requested a review from martiasu November 11, 2026 11:02
martiasu
martiasu approved these changes Nov 11, 2026
View reviewed changes
Copy link
Member

@martiasu martiasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@kfmelen kfmelen merged commit 54d1ed1 into main Nov 11, 2026
@kfmelen kfmelen deleted the 83-keep-search-and-filter-state-in-the-url-and-show-active-filters branch November 11, 2026 11:03
Sign in to join this conversation on GitHub.
Reviewers

@martiasu martiasu martiasu approved these changes

Assignees

@kfmelen kfmelen

Labels
enhancement New feature or request
Projects
None yet
Milestone
Delivery four
Development

Successfully merging this pull request may close these issues.

Keep search and filter state in the URL and show active filters
2 participants
@kfmelen @martiasu